Skip to main content

Url.ActionLink() is not thread-safe

I have an API that allows users to upload documents. To optimize the performance I save the documents to the database in parallel. After uploading has completed I return a list of URI's pointing to the document locations.

Here is what the code looks like:

As you can see in the code above, I combine a Task.WhenAll with a local function. Nothing special.

However when I executed this code under high load, I started to get errors back from the API. A look at the logs, showed the following exception:

Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: chunkLength

at System.Text.StringBuilder.ToString()

  at Microsoft.AspNetCore.Mvc.Routing.UrlHelperBase.GenerateUrl(String protocol, String host, String path)

  at Microsoft.AspNetCore.Mvc.Routing.EndpointRoutingUrlHelper.Action(UrlActionContext urlActionContext)

  at Microsoft.AspNetCore.Mvc.UrlHelperExtensions.ActionLink(IUrlHelper helper, String action, String controller, Object values, String protocol, String host, String fragment)

  at DocumentStorage.API.Controllers.DocumentsController.<UploadDocuments>g__UploadDocument|4_0(IFormFile document) in D:\b\3\_work\129\s\DocumentStorage\DocumentStorage.API\Controllers\DocumentsController.cs:line 53

  at DocumentStorage.API.Controllers.DocumentsController.UploadDocuments(List`1 documents)

It turns out that the Url.ActionLink() method is using a StringBuilder behind the scenes. And the StringBuilder is not thread-safe which brings us into trouble when we start using it in combination with the TPL.

To fix the threading issue I moved the url generation logic outside the parallel execution path:

Popular posts from this blog

DevToys–A swiss army knife for developers

As a developer there are a lot of small tasks you need to do as part of your coding, debugging and testing activities.  DevToys is an offline windows app that tries to help you with these tasks. Instead of using different websites you get a fully offline experience offering help for a large list of tasks. Many tools are available. Here is the current list: Converters JSON <> YAML Timestamp Number Base Cron Parser Encoders / Decoders HTML URL Base64 Text & Image GZip JWT Decoder Formatters JSON SQL XML Generators Hash (MD5, SHA1, SHA256, SHA512) UUID 1 and 4 Lorem Ipsum Checksum Text Escape / Unescape Inspector & Case Converter Regex Tester Text Comparer XML Validator Markdown Preview Graphic Color B

Help! I accidently enabled HSTS–on localhost

I ran into an issue after accidently enabling HSTS for a website on localhost. This was not an issue for the original website that was running in IIS and had a certificate configured. But when I tried to run an Angular app a little bit later on http://localhost:4200 the browser redirected me immediately to https://localhost . Whoops! That was not what I wanted in this case. To fix it, you need to go the network settings of your browser, there are available at: chrome://net-internals/#hsts edge://net-internals/#hsts brave://net-internals/#hsts Enter ‘localhost’ in the domain textbox under the Delete domain security policies section and hit Delete . That should do the trick…

Azure DevOps/ GitHub emoji

I’m really bad at remembering emoji’s. So here is cheat sheet with all emoji’s that can be used in tools that support the github emoji markdown markup: All credits go to rcaviers who created this list.