Skip to main content

WSFederation broken after upgrade to .NET 8

This week a colleague contacted me with an issue he encountered after upgrading to .NET 8.0. On the project involved we were using the WsFederation middleware to authenticate and interact with ADFS. However after upgrading to .NET 8 and the 8.x version of the Microsoft.AspNetCore.Authentication.WsFederation middleware the trouble began.

Using this version resulted in a change in behavior as suddenly the middleware starts to expect a SAML 2.0 token instead of a SAML 1.1 token that is now issued by our ADFS server:

XmlReadException: IDX30011: Unable to read XML. Expecting XmlReader to be at ns.element: 'urn:oasis:names:tc:SAML:2.0:assertion.Assertion', found: 'urn:oasis:names:tc:SAML:1.0:assertion.Assertion'.

Although I found a post online that it would be technically possible to let ADFS return a SAML 2.0 token through WSTrust, this doesn’t fit in the passive federation scenario we had, so time to look at some alternative solutions.

Attempt 1 – Reverting to an older package version

We first tried to rollback to an older version of the WSFederation middleware but that caused an issue in a transitive dependency. In the project we were using both Microsoft.Data;SqlClient and Microsoft.AspNetCore.Authentication.WsFederation. Both packages reference the Microsoft.IdentityModel.Tokens package as a shared dependency. However as the Microsoft.Data.SqlClient expects at least version 6.35.0 of the package and Microsoft.AspNetCore.Authentication.WsFederation expects at least version 6.10.0, version 6.35.0 of the Microsoft.IdentityModel.Tokens package is used.

Using this version resulted in a MissingMethodException as the Microsoft.IdentityModel.Tokens.InternalValidators.ValidateLifetimeAndIssuerAfterSignatureNotValidatedSaml method no longer exists in this package.

So no luck, we had to try something else...

Attempt 2 - Adding the Microsoft.IdentityModel.Tokens.Saml package

Further investigation brought me to the following issue on GitHub: Authentication.WsFederation breaks with on-premise AD FS use · Issue #52099 · dotnet/aspnetcore

Their was mentioned that explicitly adding the following NuGet package had fixed the issue:

NuGet Gallery | Microsoft.IdentityModel.Tokens.Saml 8.10.0

We followed this advice and indeed that fixed the problem.

On to the next one…

More information

NuGet Gallery | Microsoft.AspNetCore.Authentication.WsFederation 8.0.16

Obtaining a SAML 2.0 assertion from AD FS by using WS-Trust and Integrated Windows Authentication

Authentication.WsFederation breaks with on-premise AD FS use · Issue #52099 · dotnet/aspnetcore

NuGet Gallery | Microsoft.IdentityModel.Tokens.Saml 8.10.0

Labels:

Popular posts from this blog

Podman– Command execution failed with exit code 125

After updating WSL on one of the developer machines, Podman failed to work. When we took a look through Podman Desktop, we noticed that Podman had stopped running and returned the following error message: Error: Command execution failed with exit code 125 Here are the steps we tried to fix the issue: We started by running podman info to get some extra details on what could be wrong: >podman info OS: windows/amd64 provider: wsl version: 5.3.1 Cannot connect to Podman. Please verify your connection to the Linux system using `podman system connection list`, or try `podman machine init` and `podman machine start` to manage a new Linux VM Error: unable to connect to Podman socket: failed to connect: dial tcp 127.0.0.1:2655: connectex: No connection could be made because the target machine actively refused it. That makes sense as the podman VM was not running. Let’s check the VM: >podman machine list NAME         ...
Read more

Cache stampede: when our cache turned against us

While investigating some performance issues, we ran into an ASP.NET Core API that cached a fairly expensive aggregation query for 60 seconds. Under normal load, that was fine: one request rebuilds the cache, everyone else reads from it. Under peak load, dozens of requests would arrive in that same expiry window, all see a cache miss, and all fire the same expensive query in parallel. The database didn't like that. That was the moment when our caching layer stopped helping and started hurting. A burst of requests comes in at the same time, all miss the cache, and all go hammer the database or the downstream API at once. That's a cache stampede . The cache was supposed to protect our backend, and for a few hundred milliseconds it did the opposite. Why this happens IMemoryCache.GetOrCreate (and its async sibling) looks like it protects you, but it doesn't add any locking on its own. Look at the naive version: public async Task<Report> GetReportAsync(string key) ...
Read more

A complex system designed from scratch never works

A few years ago, I worked as an architect on a big mainframe rewrite. I still count it as one of my failures. Not because the technology was wrong, but because I couldn't convince the management team to simplify the approach. Years later, the organization is still struggling to get the new system up and running. I left the project at the time, because I couldn't put my name behind an approach that would take very long and cost a lot of money without a working system to show for it along the way. Gall’s Law That memory keeps coming back to me, because it's a textbook case of Gall's Law playing out in real life. Gall's Law , from John Gall's Systemantics , states it plainly: A complex system that works is invariably found to have evolved from a simple system that worked. A complex system designed from scratch never works, and it cannot be patched to make it work. You have to start over with a simple system that works. What does that mean in practice,...
Read more